search

Ketho / vscode-wow-api

VS Code extension for World of Warcraft AddOns
https://marketplace.visualstudio.com/items?itemName=ketho.wow-api
MIT License
151 stars 33 forks source link

Updates to support parsing Widget templates from the Default UI XML #17

Closed ChrisKader closed 3 years ago

Ketho commented 3 years ago

Wow thank you! But why are all the files replaced, did something change with the encoding? Because I don't see any actual differences for those image

ChrisKader commented 3 years ago

Fixed the issues with all the files that changed. My editor is setup to use LF versus CRLF and any file I touch will change to LF. Also, any file modified by bash (linux) will change to LF. It would be a good idea to change the project over to use LF versus CRLF as LF is supported by Windows and Linux where CRLF is only supported on Windows.

Ketho commented 3 years ago

Fixed the issues with all the files that changed. My editor is setup to use LF versus CRLF and any file I touch will change to LF. Also, any file modified by bash (linux) will change to LF. It would be a good idea to change the project over to use LF versus CRLF as LF is supported by Windows and Linux where CRLF is only supported on Windows.

You got a point there with Linux. I didn't know about the .editorconfig thing, hopefully that resolves the issue then when the project switches to LF.

Ketho commented 3 years ago

Thanks for all your hard work, especially with parsing the FrameXML templates and automatically downloading the wowpedia XML exports.

And even adding a .rockspec and bash script (for automatically updating builds?), although I don't have any experience with that and probably should've gone in a separate PR.

These are a massive amount of changes, I'll try to merge them but I'm not sure how stable the codebase is going to be. I do need to reconsider or rewrite some parts of the Lua code.