Ketho / vscode-wow-api

VS Code extension for World of Warcraft AddOns
https://marketplace.visualstudio.com/items?itemName=ketho.wow-api
MIT License
143 stars 31 forks source link

Ace3 support extended #30

Closed Wutname1 closed 2 years ago

Wutname1 commented 2 years ago

I got through a bunch of the more used Ace3 libraries. Due to how flexible Ace3 is on defining an addon including the ability to mixin a library latter on using the generic return that is used to LibStub just does not work right.

New items include:

There are also a few updates to a couple items that were missing parameters and tossing warnings in my code base SetFormattedText() and DisableAddOn()

Last item of note, AceLocale uses the blizzard global of GAME_LOCALE and it must be client defined as there is no definition for it anywhere in blizz LUA. I pulled the info that wowpedia lists and defined it in AceLocale-3.0.lua

Edit: If there are any sweeping changes you would like to see let me know and I can alter it.

Ketho commented 2 years ago

Concerning DisableAddOn(), the docs are generated from the wikitext so editing those files directly wouldn't work. If there is an <-- emmylua --> comment it will find that instead. I went ahead and updated the wiki. Sorry there isn't something like CONTRIBUTING.md https://wowpedia.fandom.com/wiki/API_EnableAddOn?action=edit

image

I'm conflicted now whether to still support Ace3 because it's so difficult to properly annotate it in emmylua and the flexibility you mentioned. Especially for including examples and param descriptions, I feel people should read those on the official documentation page itself.