Ketho / vscode-wow-api

VS Code extension for World of Warcraft AddOns
https://marketplace.visualstudio.com/items?itemName=ketho.wow-api
MIT License
151 stars 33 forks source link

xpcall arguments #38

Closed mrbuds closed 3 months ago

mrbuds commented 2 years ago

In 5.1 xpcall has 2 arguments, optionals were added in 5.2 WoW use 5.2 xpcall, i don't know if something can be done about it with vscode-wow-api

Ketho commented 2 years ago

I documented it as this but I don't know how to replace the definition from sumneko, will have to ask

---@param f function
---@param err function
---@vararg any
---@return boolean status
---@return ...
function xpcall(f, err, ...) end

image

Ketho commented 3 months ago

Should be fixed by replacing the LuaLS xpcall in 0.15.0 https://github.com/Ketho/vscode-wow-api/blob/2ae75ed53667b7dae7cf23840b066aca6d505029/Annotations/Lua/basic.lua#L338