Ketho / vscode-wow-api

VS Code extension for World of Warcraft AddOns
https://marketplace.visualstudio.com/items?itemName=ketho.wow-api
MIT License
151 stars 33 forks source link

C_TransmogCollection.GetCategoryCollectedCount category parameter #49

Closed DiscordGregory closed 2 years ago

DiscordGregory commented 2 years ago

The function takes a single parameter of category which is Enum.TransmogCollectionType, this type is a number but in the extension it has the type as TransmogCollectionType. There are a few functions with the TransmogCollectionType as a parameter type

image

Ketho commented 2 years ago

iirc this is working as intended, it's supposed to accept either an Enum.TransmogCollectionType enum or a number. It doesn't give any warnings for me at least...

image

DiscordGregory commented 2 years ago

Sorry it took me so long to respond, I didn't get a notification you replied :(

image

Ketho commented 2 years ago

hm thanks, that popped the warning. I will add the number type to enums, something like

---@param category TransmogCollectionType|number
---@return number count
function C_TransmogCollection.GetCategoryCollectedCount(category) end