Kethsar / ytarchive

Garbage Youtube livestream downloader
MIT License
1.04k stars 86 forks source link

Add `--proxy` option #126

Closed ipid closed 1 year ago

ipid commented 1 year ago

First of all

ytarchive is a wonderful application that has helped me download a bunch of important livestreams. Thanks for your work!

Motivation

I'm from China. Due to the Great Firewall, the YouTube users from mainland China have to use proxies to watch or download videos. Currently, when using this application, to make it connect to YouTube, a VPN software or an proxy environment variable like HTTPS_PROXY is required. I think a built-in command line option would make things easier.

This pull request may resolve #35.

Changes

I generally:

Test

I tested it myself and invited some friends to test it. The result on my computer is:

Test Result (Snapshot)

We can see that without the --proxy option, the application can't connect to YouTube. After specifying a proxy, it connects to the YouTube API and downloads video smoothly.

No bug was reported by my friends.

Kethsar commented 1 year ago

This looks good. I have some local changes I need to test on a Windows install first before I'll merge this in, and I'm not sure when I'll get to that since I am peak lazy. Thanks for the PR.