search

Kethsar / ytarchive

Garbage Youtube livestream downloader
MIT License
1.08k stars 87 forks source link

No issue but question: Stopping #59

Closed sebi-berlin closed 2 years ago

sebi-berlin commented 2 years ago

Hi,

thanks a lot for your tool. I started some downloads that happen to be live for way longer than thought or needed. Now I wanted to stop the recording to have the recording until that point.

I pressed Ctrl + C, I think after that it asked something if I want to stop, I did and then it had an error message and it deleted the 2 .ts files.

That was still when used the python-Script. Does the exe-File has some check before deleting the .ts-files?

xtkoba commented 2 years ago

I pressed Ctrl + C, I think after that it asked something if I want to stop,

I suppose you were asked

Would you like to save any created files? [y/N]:

where unless you replied an answer that starts with "y" (case insensitive), the TS files would be deleted.

You can also use the --save option to suppress the above prompt and to save them by default.

sebi-berlin commented 2 years ago

Yes, I pressed y and then it showed some error messages and then deleted the files. :-(

xtkoba commented 2 years ago

Ah, I guess it fails to move the TS files out of the temp directory (for some reason which I do not why), which is afterwards deleted regardless of success or failure to move them.

IMHO the program could be improved so that it keeps the tmpdir undeleted when some saving operation fails.

Kethsar commented 2 years ago

Yeah that's easily changed. @sebi-berlin did you get to see what those error messages were? Or did you run it by double-clicking so the console closes immediately after it's finished?

sebi-berlin commented 2 years ago

Yeah that's easily changed. @sebi-berlin did you get to see what those error messages were? Or did you run it by double-clicking so the console closes immediately after it's finished?

Great, thanks! Unfortunately I didn't save the log. It looked like something crashed, so no error that's already known via an in project error message.

Kethsar commented 2 years ago

I realized I added this in commit 1b80152a1cafd3a5045397b6df102b38b08a6e11 Closing.