search

Kethsar / ytarchive

Garbage Youtube livestream downloader
MIT License
1.08k stars 87 forks source link

nil dereference in GetDownloadUrls #78

Closed awused closed 2 years ago

awused commented 2 years ago

This occurred right at the end of a stream just after it ended.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x60 pc=0x69ea17]

goroutine 71 [running]:
main.(*DownloadInfo).GetDownloadUrls(0xc0001fe000, 0xc0001b4000)
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/Info.go:506 +0x77
main.(*DownloadInfo).GetVideoInfo(0xc0001fe000)
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/Info.go:572 +0x26f
main.RefreshURL(0xc0001fe000, {0x724221, 0x5}, {0xc0003c9b00, 0x2ff})
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/util.go:513 +0x133
main.HandleFragHttpError(0xc0001fe000, 0xc0004f7f18, 0x193, {0xc0003c9b00, 0x2ff})
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/util.go:569 +0x310
main.(*DownloadInfo).downloadFragment(0xc0001fe000, 0xc00014df18, 0xc000072f00)
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/Info.go:758 +0xd71
main.(*DownloadInfo).DownloadFrags(0xc0001fe000, {0x724221, 0x5}, 0xc000072f60, 0xc000072f00, {0xc000019150, 0x6})
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/Info.go:852 +0x191
created by main.(*DownloadInfo).DownloadStream
        /storage/cache/go/pkg/mod/github.com/!kethsar/ytarchive@v0.3.0/Info.go:891 +0x570
Kethsar commented 2 years ago

>Attempted fix is a no-op I fucking hate this.

Kethsar commented 2 years ago

Was probably fixed in f89a4556f0fca8d87316e593e27c104da674bc07 and go is shit and was pulling a phantom tagged version and just, fuck Golang sometimes.