search

Kethsar / ytarchive

Garbage Youtube livestream downloader
MIT License
1.15k stars 93 forks source link

mp4 file not building on windows #96

Closed erffle closed 2 years ago

erffle commented 2 years ago

I use ytarchive on Windows. The mp4 build stage doesn't go through because ytarchive uses single quotes when passing paths to ffmpeg, but Windows only understands double quotes. Is there any way to fix this?

Kethsar commented 2 years ago

I have tested on windows and don't recall encountering this, but then I cannot recall if the file path ended up with any spaces in it. Can you paste what error ffmpeg ends up spitting out?

erffle commented 2 years ago

Yes, spaces in the path. After recording, I found file with the extension .ffmpeg:

ffmpeg -hide_banner -nostdin -loglevel fatal -stats -i 'E:\Видео\Странное местечко_20220624_ПЯТНИЧНЫЙ БАЛДЁЖ.f140.ts' -i 'E:\Видео\Странное местечко_20220624_ПЯТНИЧНЫЙ БАЛДЁЖ.f299.ts' -movflags faststart -c copy 'E:\Видео\Странное местечко_20220624_ПЯТНИЧНЫЙ БАЛДЁЖ.mp4'

Windows does not execute this command, but if you change the quotes to double, then it does.

Kethsar commented 2 years ago

Have you tried using powershell to run the command instead of cmd?

erffle commented 2 years ago

Through powershell it ran!

Kethsar commented 2 years ago

Yeah, cmd is basically a DOS terminal emulator. It has a lot of ass-backwards things that make it annoying to use, and use is typically discouraged. Powershell or a *nix shell are always better options.