Parsing ingredients - Githubissues

Keto-Eating / Keto-Recipe-API

This API serves up keto recipes, and is a micro-service for a larger project that will eventually serve up grocery lists based on saved recipes.

11 stars 15 forks source link

Parsing ingredients #67

Closed nsafai closed 5 years ago

nsafai commented 5 years ago

Currently parsing and rendering ingredients on grocery list page (/cart/grocery-list)

HOW TO TEST

npm i
nodemon
Login
Add recipes to cart
Go to /cart/grocery-list

NOTES Note that the parsing is not 100% perfect but it works for 90% of ingredients. Future improvements that I suggest upon refactoring:

[x] create an IngredientLine class, that has properties like quantity, unitOfMeasurement, description, yield, pointerToRecipe (this pointer will be useful if user wants to update yield of a specific recipe)

What is not finished (could be merged without doing these, to be discussed)

[ ] polish grocery list view
[ ] save when users check off a box, see TODO comment in grocery-list.hbs or don't use checkboxes for now
[ ] combining similar ingredients and/or sorting of any kind other than by recipe

phylliswong commented 5 years ago

Great work Nico! I noticed that the PR was requesting to merge the branch into the master, so I changed it to develop.