search

Kev049 / TDA553-lab

0 stars 0 forks source link

Lab 3 #3

Open dinohromic opened 1 year ago

dinohromic commented 1 year ago

TASK 1: It looks good

TASK 2-4: Nothing to comment on here, due to the implementations of these tasks are shown in task 5.

TASK 5: It looks good. The refactoring is good. The only comment I have is that the controller and view in a larger program would lie in two separate packages. All the controllers could be in a package called controller whereas all things related to views should lie in a package called View or similar. The composition of the functionality is well done.

Comment: Good job!

Kev049 commented 1 year ago

We were considering that option but we were a bit doubtful as it we only had 1 controller. We do appreciate the feedback though, and will definitely keep it in mind for future projects!

dinohromic commented 1 year ago

Nej det är inga problem. Blev kanske skumt att det blev mycket på engelska men det är mest för i fall Robin själv också skulle vilja läsa någonting. Men som sagt det är ingenting ni behöver tänka på i nuläget. Dock är det värt att tänka på senare när ni i Lp1 ska göra ett objekt orienterat projekt. Då kommer ni vara tvungna att tänka på fördelningen mellan paketen också. Det var en väl genomförd uppgift. Lycka till med er written assignment! Mvh // Dino Hromic [TA]

Den tis 13 dec. 2022 kl 23:49 skrev Kevin Collins @.***

:

We were considering that option but we were a bit doubtful as it we only had 1 controller. We do appreciate the feedback though, and will definitely keep it in mind for future projects!

— Reply to this email directly, view it on GitHub https://github.com/Kev049/TDA553-lab/issues/3#issuecomment-1349952267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWKTEJI3BWDESKLPCISUHH3WND4P5ANCNFSM6AAAAAAS5V2OQA . You are receiving this because you authored the thread.Message ID: @.***>