KevM / tikaondotnet

Use the Java Tika text extraction library on the .NET platform
http://kevm.github.io/tikaondotnet/
Apache License 2.0
195 stars 73 forks source link

Upgrade to Tika 1.17 #112

Closed nixa333 closed 6 years ago

nixa333 commented 6 years ago

Hi there,

are you planning to upgrade to Tika 1.17?

KevM commented 6 years ago

Thanks for letting me know 1.17 is out.

Do you want to create a PR for it? There is a guide on how to do it. 💃

nixa333 commented 6 years ago

I have to say I'm not skilled with the procedures around pulling Git repos(never did this before), but I tried following the guide. When I try to push new version on newly created branch 1.17 I get an error:

git push origin 1.17 --tags remote: Permission to KevM/tikaondotnet.git denied to nixa333. fatal: unable to access 'https://github.com/KevM/tikaondotnet.git/': The requested URL returned error: 403

Do you have to grant me permissions to be able to do this? Btw, how do I change the nupkg name to include new version name, because it keeps creating files with 1.16.0.nupkg sufix?

KevM commented 6 years ago

Thank you for trying! I think you should create a PR. https://help.github.com/articles/creating-a-pull-request/ And then I'll merge it and tag the release and your contribution will have created a 1.17 nuget. I'll try to update the contribution docs with this detail.

On Thu, Feb 15, 2018 at 7:07 AM Nikola Biondic notifications@github.com wrote:

I have to say I'm not skilled with the procedures around pulling Git repos(never did this before), but I tried following the guide. When I try to push new version on newly created branch 1.17 I get an error:

git push origin 1.17 --tags remote: Permission to KevM/tikaondotnet.git denied to nixa333. fatal: unable to access 'https://github.com/KevM/tikaondotnet.git/': The requested URL returned error: 403

Do you have to grant me permissions to be able to do this?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/KevM/tikaondotnet/issues/112#issuecomment-365921900, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAGHe1-5raeSegT1-pFdKmr0WdFz02rks5tVCv-gaJpZM4R89Et .

KevM commented 6 years ago

Looks like I already have some guidance there.

nixa333 commented 6 years ago

Done.