search

KevWK314 / ThreeFourteen.AlphaVantage

.NET library for Alpha Vantage
MIT License
9 stars 9 forks source link

IAlphaVantage for mocking and DI? #5

Closed VictorioBerra closed 4 years ago

VictorioBerra commented 5 years ago

Can we get an interface for the AlphaVantage client so it can be dependency injected and later mocked in unit/integration tests?

KevWK314 commented 5 years ago

Hi Victorio

I purposely didn't create interfaces for everything. You could wrap the calls to AlphaVantage in your own custom interfaced implementations. An additional bonus of that approach is you limit the dependency on a specific implementation of an AlphaVantage client.

Kevin

VictorioBerra commented 5 years ago

Ah the adapter pattern. Alrighty thanks.

On Tue, Mar 19, 2019, 10:52 AM KevWK314 notifications@github.com wrote:

Hi Victorio

I purposely didn't create interfaces for everything. You could wrap the calls to AlphaVantage in your own custom interfaced implementations. An additional bonus of that approach is you limit the dependency on a specific implementation of an AlphaVantage client.

Kevin

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KevWK314/ThreeFourteen.AlphaVantage/issues/5#issuecomment-474438109, or mute the thread https://github.com/notifications/unsubscribe-auth/ACzG62Cc1I3d7hC9A6gu7qySGlsF7LG6ks5vYQe_gaJpZM4b3hrI .