search

Kevin-Bronsdijk / kraken-net

Official Kraken.io .Net client
https://kraken.io
GNU General Public License v2.0
19 stars 5 forks source link

Custom Image Quality functionality - > added new property in Optimize… #6

Closed pateljan closed 7 years ago

pateljan commented 7 years ago

Updated the library to support Custom Image Quality feature with Lossy image optimization. As per specified in kraken documentation below.... https://kraken.io/docs/custom-image-quality.

Model.OptimizeRequestBase.Quality

Kevin-Bronsdijk commented 7 years ago

Thank you for creating the PR. I will merge the changes and create a new release this evening.

Kevin-Bronsdijk commented 7 years ago

Hi, you forgot to write an integration test to make sure all is working fine after applying the changes. In addition, the value is optional, but within your implementation, this is not the case.

This behavior should be visible in the new tests. The old calls without the value should still be woking fine even if not providing a value. Now you render a result within the output which defaults to 0.