search

Kevin-Rau / breakfast

0 stars 4 forks source link

Review for HW2 #5

Open ridler opened 9 years ago

ridler commented 9 years ago

To make Node projects more portable (so that it's easy for people like me to clone your repository and run your code), make sure you add all your dependencies to the package.json file.

So if you're using moment.js, do npm install --save moment, and it will be saved as a dependency. So then people who clone the repo can just run npm install and then they will get all of the needed things.

You should also echo node_modules/ >> .gitignore before you push to GitHub.

Lastly, a write-up of your API would be nice so that I could know how to use the app without reading all of the route code.

kenbod commented 9 years ago

I love all of the constructive comments. Your reviewers are nudging you to produce a better system. Please make sure you respond to the comments and clean up the code such that you have a functional web service. Thanks.