search

KevinBatdorf / liquidslider

A Responsive jQuery Content Slider
161 stars 62 forks source link

Make it compatible with browser without css animation an jquery.easing #104

Closed o0x2a closed 10 years ago

o0x2a commented 10 years ago

If a user didn't include jquery.easing.1.3.js in their script and use a browser without CSS animation like IE8, a user would receive Object doesn't support property or method 'easeInOutExpo' from jQuery and the slider wouldn't run.

It happens because the liquid slider use the default animation easeInOutExpo and since the user didn't include jquery.easing.1.3.js the jquery returns an error when trying to use the easing.

To fix this we can check if jQuery support the easing, if it doesn't we fallback to swing easing which is supported by default.

This is not a bug fix, it is more an enhancement to remove the strict requirement of jquery.easing.1.3.js script.

KevinBatdorf commented 10 years ago

Wouldn't the slideEaseFunctionFallback: "easeInOutExpo" work the same? I suppose I could set that as 'swing' by default instead.

KevinBatdorf commented 10 years ago

Ok, I see what you mean. Good idea. I'm doing a big update on the slider now. I'll add this in manually.