When transition set to fade callback fires twiceq

[theframework]

HI Kevin,

Hope all is well.

The callback function fires twice when fading between slides... Any ideas why this may be? Have tried debugging but no joy... Works find if sliding!

Cheers

[KevinBatdorf]

Are you using the most current version? What other settings are you using?

[theframework]

HI KevinŠ

Yep using the most recent version (v2.0.12) as downloaded from your site. The settings below are what I am using at the moment. But I need it to fadeŠ so when I change slideEaseFunction to Œfade¹ the callback fires twice. Works fine as is.

Thanks for your help.

_this.get('Container').liquidSlider({ autoSlide : true, autoSlideInterval : 10000, slideEaseDuration : 1500, slideEaseFunction : "easeInOutExpo", continuous : true, fadeInDuration : 500, fadeOutDuration : 500, dynamicArrowsGraphical : false, dynamicTabs: false, autoHeight : false, hoverArrows : false, responsive : false, panelTitleSelector : ".slider_title", callback: function() {

var View = _this.get('Container').find('.currentPanel').attr('id') _this.initView(View) } }); var api = $.data( _this.get('Container')[0], 'liquidSlider'); api.finalize(); THIS IS BEING CALLED AS IT IS LOADED AFTER WINDOW LOAD

From: Kevin Batdorf notifications@github.com Reply-To: KevinBatdorf/liquidslider <reply+i-26835010-76620125fd200207b97e86efe928127472b7e84c-3763158@reply.git hub.com> Date: Tuesday, 4 February 2014 08:11 To: KevinBatdorf/liquidslider liquidslider@noreply.github.com Cc: Rich Cooper rich@theframework.co Subject: Re: [liquidslider] When transition set to fade callback fires twiceq (#108)

Are you using the most current version? What other settings are you using?

‹ Reply to this email directly or view it on GitHub https://github.com/KevinBatdorf/liquidslider/issues/108#issuecomment-340383 84 .

[KevinBatdorf]

Hey, when I use those settings it calls the callback once (with fade). Can you put it online somewhere?

[theframework]

Hi Kevin,

The app is now online at the following address http://theframework.co/dev/generationgreen/

I have put a console.log(Œcallback¹) in the callback function so that you can see it firing twice each time the system fades between slides. Like I said beforeŠ it fires only once when sliding

Could you please advise why this may be?

Thanks in advance

From: Kevin Batdorf notifications@github.com Reply-To: KevinBatdorf/liquidslider <reply+i-26835010-76620125fd200207b97e86efe928127472b7e84c-3763158@reply.git hub.com> Date: Thursday, 6 February 2014 13:25 To: KevinBatdorf/liquidslider liquidslider@noreply.github.com Cc: Rich Cooper rich@theframework.co Subject: Re: [liquidslider] When transition set to fade callback fires twiceq (#108)

Hey, when I use those settings it calls the callback once (with fade). Can you put it online somewhere?

‹ Reply to this email directly or view it on GitHub https://github.com/KevinBatdorf/liquidslider/issues/108#issuecomment-343221 55 .

[mnakalay]

I can confirm that on that example website, the callback is called twice first by the transitionFade Function (with a timeout) and second by the transition function (also with a timeout)

[theframework]

Thanks for your responseŠ Could you confirm the fix please?

From: mnakalay notifications@github.com Reply-To: KevinBatdorf/liquidslider <reply+i-26835010-76620125fd200207b97e86efe928127472b7e84c-3763158@reply.git hub.com> Date: Tuesday, 11 February 2014 15:13 To: KevinBatdorf/liquidslider liquidslider@noreply.github.com Cc: Rich Cooper rich@theframework.co Subject: Re: [liquidslider] When transition set to fade callback fires twiceq (#108)

I can confirm that on that example website, the callback is called twice first by the transitionFade Function (with a timeout) and second by the transition function (also with a timeout)

‹ Reply to this email directly or view it on GitHub https://github.com/KevinBatdorf/liquidslider/issues/108#issuecomment-347632 82 .

[theframework]

Hi,

Thanks for getting back to me and letting me know the cause.

From the below I do not understand how I can stop the callback from firing twice. Could you please confirm the fix for this please.

THanks

From: mnakalay notifications@github.com Reply-To: KevinBatdorf/liquidslider <reply+i-26835010-76620125fd200207b97e86efe928127472b7e84c-3763158@reply.git hub.com> Date: Tuesday, 11 February 2014 15:13 To: KevinBatdorf/liquidslider liquidslider@noreply.github.com Cc: Rich Cooper rich@theframework.co Subject: Re: [liquidslider] When transition set to fade callback fires twiceq (#108)

I can confirm that on that example website, the callback is called twice first by the transitionFade Function (with a timeout) and second by the transition function (also with a timeout)

‹ Reply to this email directly or view it on GitHub https://github.com/KevinBatdorf/liquidslider/issues/108#issuecomment-347632 82 .

[mnakalay]

I think you need to give Kevin a little time to deal with it

[KevinBatdorf]

Yeah, I've been busy the past few weeks. I'll have a few days of free time and will look into this asap. Sorry for the delay

[KevinBatdorf]

I'm looking through this again and I can't find where a callback is being fired twice. I checked the demo link, but it required a password now :(

I'll leave this issue open in case anyone else has this come up.