search

KevinBatdorf / liquidslider

A Responsive jQuery Content Slider
161 stars 62 forks source link

Tab indexes on input fields breaks layout #94

Closed adamnye closed 10 years ago

adamnye commented 10 years ago

Firstly, love the slider - epic win.

Secondly, something that ive noticed, and causes issues for my particular project...

When you tab between inputs, it'll pickup inputs on the next (inactive) panel, which causes it to force that panel into view (tested on desktop & tablets).

The (quick) work around im using at the moment uses JS to disable any other inputs on screen when one has focus, completely disabling the option to tab. This works, but would be frustrating for users with significant data-entry tasks.

The only suggestion i have to remedy this is to either disable the inputs or setting their visibility to hidden on any inactive panels, removing the possibility for it to be tabbed to.

Adam Nye

KevinBatdorf commented 10 years ago

I think this would be up to the developer to add and not for the slider to handle natively. Do you agree? But it does make me want to add some way to show which panel is current. I think I'll add a class of currentPanel in the next up date.

Thanks for the feedback though, it helps a lot.

adamnye commented 10 years ago

Its your call dude .. But i would class this as a bug personally. You've done such a great job of making it work responsively (assumingly to seamlessly render on mobile / tablets), but these prev / next-input buttons (IMO) are kind of an 'achilles heel'. Unlikely, but possible.

I've made the modifications i needed for my project, and am massively appreciative of your work. So im happy.

Just trying to help - not try to give you more work : )

Good luck.

p.s currentPanel would be handy. From that it would also be easier to detect which panels arent in view. Happy days.

KevinBatdorf commented 10 years ago

Just FYI to anyone reading this later, currentPanel is added as of version 2.2