search

KevinBockelandt / notoire

A vim plugin to take notes using the Zettelkasten method
MIT License
53 stars 6 forks source link

`notoire_file_extension` is not used when creating links #30

Closed nakedpony closed 4 years ago

nakedpony commented 4 years ago

When I set up notoire_file_extension = 'md' and create a new zettel with :NotoireCreateLink it creates link like the following [second one](2) which is not a valid link when commiting this to github. Is there a possibility to create the link with the extension like this: [second one](2.md)? Thank you.

KevinBockelandt commented 4 years ago

Hello,

I'm not sure what you mean by "it's not a valid link committing this to github".

It is the intended behavior that no file extension is displayed in the notes (for clarity). It's all handled internally.

Is there something you want to achieve in particular with the file extensions?

nakedpony commented 4 years ago

Hello Kevin,

Sorry for not making it clear. So I created a test repository on github to show it: https://github.com/nakedpony/zettel If you click first link from README.md it will not work, but the second one will.

Thanks!

KevinBockelandt commented 4 years ago

Thanks I see now. I added an option to add the file extension in the links: https://github.com/KevinBockelandt/notoire/blob/5dd9b3f4e94eef1bd220699ca386118b6dcbf260/doc/notoire.txt#L140

Beware though that links should be consistent. All of them without extensions or all of them with extensions and the option active. If they are mixed some search features of Notoire will not work properly.

Tell me if that's ok with you :)

nakedpony commented 4 years ago

Hey Kevin,

Thank you so much for making changes so quickly. It works perfectly now!

Cheers, Sergey.