search

KevinDaGame / VoxelSniper-Reimagined

The premier long-distance brush editor for Minecraft, reimagined!
GNU Lesser General Public License v2.1
62 stars 6 forks source link

Filldown brush fails below Y=0 [BUG] #237

Closed Klime65536 closed 6 months ago

Klime65536 commented 6 months ago

Describe the bug The filldown brush always stops when Y=0 regardless of the actual bottom limit of the world or how far down the next surface is. Right clicking blocks below Y=0 does nothing, blocks at 0 or above produce a weird "lid" of material which stops at Y=0.

To Reproduce Steps to reproduce the behavior:

  1. Load into a world (preferably superflat) with a minimum height value below 0.
  2. Set up some basic terrain with some above 0, some below 0
  3. Use /b fd to try to fill the areas below Y=0 with any material
  4. Confirm that the brush will never modify blocks with a y value <0

Expected behavior The filldown brush should fill down to either the nearest surface or the world bottom regardless of the dimension's minimum height.

Desktop (please complete the following information):

KevinDaGame commented 6 months ago

Thanks for the report. I will try to look into it soon

KevinDaGame commented 6 months ago

@Klime65536 This should be resolved in #238. This jar contains the fix. To ensure it is fixed, could you run this jar to see if it resolves your issue? (The jar is zipped because github doesn't allow uploading jars in comments) voxelsniper-8.13.1-beta-spigot.zip

Klime65536 commented 6 months ago

@KevinDaGame It does indeed resolve the issue :)

KevinDaGame commented 6 months ago

Glad to hear it. That jar is safe to continue using. I will attempt to put out an official release over the weekend