search

KevinDockx / JsonPatch

JSON Patch (JsonPatchDocument) RFC 6902 implementation for .NET
MIT License
174 stars 28 forks source link

Look into non-generic overloads for creating ops & non-generic JsonPatchDoc #64

Open KevinDockx opened 7 years ago

KevinDockx commented 7 years ago

Might conflict with JsonPatch.Dynamic?

cfr https://github.com/KevinDockx/JsonPatch.Dynamic/issues/10#issuecomment-273648173

HappyNomad commented 7 years ago

The two non-generic JsonPatchDocument classes would be in different namespaces, so the "conflict" is manageable.

KevinDockx commented 7 years ago

Yep, but the thing is that we'd end up with two classes that are copies of each other but just live in a different namespace - and that's not right. The best way to solve this from a design POV would be to move the non-generic JsonPatchDoc to this lib, and remove it from JsonPatch.Dynamic altogether, but that means a breaking change in JsonPatch.Dynamic. That could be mitigated by marking it as obsolete in JsonPatch.Dynamic (and remove it altogether later on) - what do you think?

HappyNomad commented 7 years ago

That approach sounds fine to me.