search

KevinJump / uSync

Database syncing tool for Umbraco CMS
https://jumoo.co.uk/usync/
Mozilla Public License 2.0
109 stars 63 forks source link

RC4 - Properties not showing in inherited tabs after import #643

Closed OwainJ closed 4 months ago

OwainJ commented 4 months ago

Describe the bug I have two compositions which both include a Content tab, and a DocType which composes these that also adds it's own property to the Content tab.

After importing into Umbraco 14 RC4, using uSync v14 RC4, the DocType's property shows up in the Generic Tab, rather than the inherited Content tab.

To Reproduce Steps to reproduce the behavior:

  1. Using Umbraco 13
  2. Create a Composition, which has a Content tab
  3. Create a DocType that inherits the composition and add it's own property to the Content tab
  4. Perform a uSync Export
  5. Copy the exported uSync files to a blank Umbraco 14 RC4 install
  6. Run a uSync import
  7. Check the DocType to see if the property is in the Content tab or not

Expected behavior The DocType's property should be in the Content tab

Screenshots Left: v14 - Right: v13 DocType usync tab issue This screenshot shows the property Body Text in the Generic tab on v14, whereas it was inside of the Content tab on v13.

About your Site (please complete the following information):

Additional context

herobannercomposition.config ``` Hero Banner Composition icon-defrag folder.png False False Culture true False Compositions 1a5715b1-ac1e-4eff-923d-a1276ce1818b Hero Banner Image heroBannerImage 632d2ba0-656b-40d2-89a1-5178c8cb87a5 Umbraco.MediaPicker3 false 2 Hero Banner Nothing false e96d1181-5fd3-45c1-83e6-ef86867c646a Hero Banner Subtitle heroBannerSubtitle 49cebe1f-a440-4dfc-a9c3-5e1c87c1cd50 Umbraco.TextArea false 1 Hero Banner Culture false 026cddde-72f4-4251-a147-334a98167503 Hero Banner Title heroBannerTitle 704c6d8c-1e00-4ef1-bb3a-5fd82ab9fad8 Umbraco.TextArea false 0 Hero Banner Culture false 145a1269-f4b1-4fb1-aaca-f08155e6a753 Content content Tab 0 a15a2dc7-79c9-432f-bdc6-d0c1b37c2ab7 Hero Banner content/heroBanner Group -10 ```
contentpage.config ``` Content Page icon-article color-black folder.png False False Culture false False Pages blockListDefaultComposition heroBannerComposition pageSettingsComposition ContentPage 039b8a25-b47a-4a0c-8dff-ba506a20bc7b Body Text bodyText ca90c950-0aff-4e72-b976-a30b1ac57dad Umbraco.TinyMCE false -1 Content Culture false fc5bb328-ef89-4468-b2aa-c128f433279c Content content/content Group 0 ```
KevinJump commented 4 months ago

yep can reproduce.

oddly it all works if there is a property in the root, (it looks like if the second page is missing the tab definition then it doesnt work)

KevinJump commented 4 months ago

Fixed this today:

In v14 we must explicitly create the parent "tabs" in the content type when the parent is from a composition.

https://dev.azure.com/jumoo/Public/_artifacts/feed/nightly/NuGet/uSync/overview/14.0.0-rc4.20240528.7

KevinJump commented 4 months ago

re-open . not quite fixed, works on first import, breaks on subsequent imports 😢

KevinJump commented 4 months ago

Fixed (again) - our tab cleanup was removing the tabs because they have not explict properties, they are now not removed if they are also inherited

KevinJump commented 4 months ago

https://dev.azure.com/jumoo/Public/_artifacts/feed/nightly/NuGet/uSync/overview/14.0.0-rc4.20240528.14