search

KevinKelly25 / LearnSQL

LearnSQL, a website for learning SQL
1 stars 2 forks source link

AngularJS incompatibility with Internet Explorer 11 #59

Open cinnaco opened 6 years ago

cinnaco commented 6 years ago

The majority of the pages on the website which utilizes AngularJS, do not work with Internet Explorer 11. This is apparent because elements which should be hidden, are visible and ng-model variables are not filled with the appropriate data. This is important to fix because IE still holds a significant part of overall browser usage and some institutions force the use of IE through group policy.

KevinKelly25 commented 6 years ago

Thank you @cinnaco for logging this issue and doing the testing on various browsers.

I believe this issue is being caused because of the use of arrow functions in AngularJS. After doing some research I found that arrow functions are not supported by internet explorer 11 and many other things. To see a more complete list you can go here.

There might be a simple solution of using https://babeljs.io/ to convert the angularjs controllers from es6 to es5. If it is as easy as just using that converter we can use it before milestone 1 release this weekend. Otherwise, we can move it to Milestone 2.

I did a test with mainControllers.js with the babeljs converter and index.html worked perfectly with ie11.