Updated middleware for create/drop class functions from DB

[michaeltorres1]

In this PR I have updated the middleware in order for the createClass and dropClass functions in order for the user to be able to create a class and drop a class through using the interface in teacherClasses.html. I also have updated some comments and added comments as well. In the function createClass in teacherControlPanel.js I have added parameters to reflect what is needed from the createClass function from classMgmt.sql. I have tested this PR and works on my end.

Please be sure that your user created has the attribute isTeacher to true in order to access the classes tab.

[michaeltorres1]

After noticing some issues with my PR I have made a couple of updates...

• The date was incorrectly formatted in the table on the user interface for teacherClasses.html. I have updated the PR to reflect this change. The date is now shown correctly. After doing some research the added characters at the end of the date were there because by default JavaScript displays the browsers time zone. Because we only want the date to be shown, the date had to be reformatted using a function convertDate which was already defined in profileController.js. However, after adding this function to teacherController.js the above function did not work because in my case it was expecting three parameters which I was able to concluded when trying to use the new Date constructor. So in order to make it work I had to add in teacherClasses.html the pipe symbol | which takes the output on the left, for both startDate and endDate, and pipes it to the right.
• I also ran npm run pretest for linting. After the process, I had fixed the issues and no errors are shown now. As a result I have deleted some variables and modules that were included that were unused such as uniqid in teacherControlPanel.js and some console.log methods that were only needed for testing purposes. Also some other changes were made to comply with the rules stated in the ESLint documentation.

Please make sure to check that the date is displayed correctly. Also by running --fix to automatically fix most of the issues that were found by linting, please make sure that this process did not make any unwanted changes.

[KevinKelly25]

Thank you for the update. I am seeing a few things that need to get fixed:

• The classdb folder in db should be removed since we are doing all classdb related db operations in modified classdb repo now.
• There is no error logging for server errors. Should be logger.error(createClasss: \n${error}); above the last general error that logs an unexpected error. This is true for drop class as well
• The date is also messed up on the class page which needs to be converted as well.
• Although not part of your PR the new schema qualifiers added to the classMgmt DB port PR broke the join class page and the schema qualifiers need to be added back. Since this PR is a follow up to that and we missed that error it would make sense to fix it in this PR. Also 'getStudents` function has this issue.
• The above issue also needs to be fixed in joinClass and getClasses for student. The date there is wrong as well. In joinClass you will also need the following on line 72 since the passwords are now hashed: if (!authHelpers.compareHashed(req.body.password,result2.password))
• You took away the date/time conversion on the times for student list which needs to be added back.
• Although not specifically part of this PR once we allow users to connect/query class if a connection is active when dropping class it will not allow class to drop. (as I just found out). We need to make an issue for this so we can address this in another PR more related to that issue.
• If there is no join password supplied the error is not displayed correctly
• In teacherControlPanel.js there is a empty param in comment for dropClass(req, res).

The | date for the dates is a pretty cool feature I did not know about. Good find 👍

[michaeltorres1]

Thank you for the review @KevinKelly25. I have fixed all the issues besides for bullet point 7 which does not fall into the scope of this PR. I agree we need to fix this soon however in the mean time I will go ahead and make an issue for this.

[michaeltorres1]

I went ahead and fix merge conflicts so that there isn't any problems for approving the PR.

[cinnaco]

Thanks @michaeltorres1. This PR functions well after the issues noted by @KevinKelly25 were corrected. After reviewing the code, I have only one suggestion: when a teacher creates a class through the Add Class modal, the Join Password textbox should obfuscate the password. The teacher can always check the password before submitting using the browser supplied "peek" functionality.

[michaeltorres1]

Thank you @cinnaco for your observation. I agree that the password should be obfuscated. I went ahead and masked the password so now all you should see is asterisks instead of the actual password.