search

KevinKoobs / xBuyTangem-issues

0 stars 0 forks source link

Variable instead of value in help text #5

Closed NetScr1be closed 10 months ago

NetScr1be commented 10 months ago

Issue Description

In the Get Cards > Xumm Card Properties the variable $(props.token) appears instead of the intended text (network name?).

See attached screenshot:

image

Steps to reproduce

  1. Open xApp
  2. Select Order Cards
  3. Scroll down to then select Xumm Card Properties

Error Messages

N/A

Account Address

Device Info

NetScr1be commented 10 months ago

Is the variable name supposed to be meaningful?

KevinKoobs commented 10 months ago

No it's not, it's code that should have been executed but didn't because of quotes ;P

Fixed in https://github.com/XRPL-Labs/xBuyTangem/commit/6bdb3ded4a19109bc6faf0a730aeff960c42f1e2