search

KevinOConnor / can2040

Software CAN bus implementation for rp2040 micro-controllers
GNU General Public License v3.0
686 stars 68 forks source link

this fixes a compilation issue when using SDK v2.0.0, should also wor… #55

Closed hdumcke closed 1 week ago

hdumcke commented 3 months ago

…k with previous versions

BTW, I am using CMake with pico_sdk_import.cmake which sets the version string. Other compile environments must set PICO_SDK_VERSION_MAJOR when v2 is used

danielstuart14 commented 2 months ago

I think it would be better to check for PICO_SDK_VERSION_MAJOR == 1, as it would guarantee compatibility with future versions of the SDK (if no other breaking change is done to the subsystems being used)

hdumcke commented 2 months ago

I agree, I was less optimistic on the longelevity as you are. Please amend the PR

KevinOConnor commented 2 months ago

Thanks.

I agree we'll need to change the code to support the latest version of the sdk. Unfortunately, it looks like pio_sm_hw_t was introduced in v1.3.0 of the SDK, and I also maintain code which currently uses v1.2.0 of the SDK.

I don't think using PICO_SDK_VERSION_MAJOR is a good option as it would introduce a dependency on the build environment (that define is only introduced by the SDKs build tools, not in any of its standard code files).

So, I agree we'll need to make a change, but it'll take a few more weeks for me to be ready to make a change (and document the dependencies).

Cheers, -Kevin

github-actions[bot] commented 2 weeks ago

Hello,

It looks like there hasn't been any recent updates on this github ticket. We prefer to only list tickets as "open" if they are actively being worked on. Feel free to provide an update on this ticket. Otherwise the ticket will be automatically closed in a few days.

Best regards,

~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.