search

KevinParnell / OneeChan

Customizable rice and themes for 4chan X
Other
346 stars 22 forks source link

Expanding certain sized images cause the post text to appear incorrectly. #7

Open Chuunie opened 6 years ago

Chuunie commented 6 years ago

Here's an example. When expanded the above image causes the text to appear incorrectly, the below image is an example of how the text should appear upon expanding an image.

example

KevinParnell commented 6 years ago

I am unable to reproduce this error. Turned off fixed width as well. Do you mind posting to that exact post so I can see it?

Chuunie commented 6 years ago

Here's another random example. https://boards.4channel.org/c/thread/3288902 I dunno how to link so it scrolls you to the post but it's post 3292929.

Chuunie commented 6 years ago

I just noticed if I resize my window to be smaller than the post box size it does not occur maybe that's why it could be tricky to reproduce. Here's what I mean. The first image my window is maximised and therefore bigger than the post box size, the bug occurs. The second image the window is resized so the post box has to scale a little bit with it, the bug does not occur. capture1 capture2

KevinParnell commented 6 years ago

I am still unable to reproduce it.

screen shot 2018-11-30 at 12 19 49 pm screen shot 2018-11-30 at 12 20 08 pm screen shot 2018-11-30 at 12 21 03 pm screen shot 2018-11-30 at 12 21 43 pm

I'm testing this on my 13in MacBook Pro on Safari right now. I can take a look on my 1080p Windows 10 desktop on Edge and my 1080p Linux ThinkPad on Chrome in a bit. Can I get some more information on your web browser and screen resolution and whatnot?

KevinParnell commented 6 years ago

Can you also send me your 4chanx and oneechan settings? Mine can be found in the GitHub, can you also test the settings I use?

KevinParnell commented 6 years ago

Another user in my discord is unable to reproduce this in Firefox and chrome.

Chuunie commented 6 years ago

I'm using chromium Version 70.0.3538.110. I reset all of my 4chan x settings and oneechan to default and then only turned off fit width in oneechan and it still happens. My guess is that it can't be reproduced because of the resolution. Try this one. https://boards.4channel.org/g/thread/68706075 post number 68708604.

KevinParnell commented 6 years ago

Hmm, now it did it.

screen shot 2018-11-30 at 2 38 04 pm

I'm not sure what's causing this, how often does it happen? I'll look into this particular case more over break. It seems to be infrequent at least though, but yeah a bit of an annoyance.

Chuunie commented 6 years ago

Maybe 1 in 10 images. It seems to be dependant on the aspect ratio and resolution of the image.

KevinParnell commented 5 years ago

I have now decided to leave this as a feature.