Launch on Safari - Githubissues

KevinPayravi / indie-wiki-buddy

Browser extension that automatically notifies and redirects you to independent wikis.

https://getindie.wiki

MIT License

241 stars 66 forks source link

Launch on Safari #36

Open KevinPayravi opened 1 year ago

KevinPayravi commented 1 year ago

A bit more overhead but shouldn't be too difficult.

Guide for converting existing extensions to Safari: https://developer.apple.com/documentation/safariservices/safari_web_extensions/converting_a_web_extension_for_safari

KevinPayravi commented 1 year ago

Did an initial run of converting the extension to Safari; looks like it is going to take a lot of code changes to make it fully compatible.

MichaelJBerk commented 7 months ago

I've been able to convert the extension to use it with Safari without needing to make major changes to the existing code https://github.com/MichaelJBerk/indie-wiki-buddy

KevinPayravi commented 7 months ago

@MichaelJBerk That's awesome, thank you! 🎉 I'll test it out.

yinyue200 commented 2 months ago

Any news？

pleonasticTautology commented 2 months ago

we would also appreciate any updates on this.

MichaelJBerk commented 2 months ago

Sorry for the late response. I've been able to get stuff working on my fork, with a few caveats:

I have to use another method to watch pages, since a Safari extension non-persistent background page cannot listen to webRequest events. Specifically, I have it add a listener to onTabUpdated instead.
It seems that Safari Extensions can't have notifications for some reason, so that option will need to be removed on Safari
When trying to decompress search engine and wiki settings, Response.blob() fails because it expects an ArrayBuffer for some reason. No idea what the specific cause of this is.

KevinPayravi commented 2 months ago

I have a branch on this main repo called safari that I also got largely working on Safari. Like Michael mentioned, we have to use a different method to capture navigation, and notifications had to be commented out.

With this commit, I changed how decompression works in scripts/common-functions.js and it should work across all browsers smoothly now.

I believe this branch is nearly ready for deployment to the App Store. The biggest remaining task I've been working on is the app landing page for iOS. iOS users need to enable Indie Wiki Buddy per-domain, so we need to adequately communicate this to users on-install.

MichaelJBerk commented 2 months ago

Installed it to my iPad and it seems like the popup doesn't have a proper minimum width

Also, none of the css for the settings or popup seem to load, since the css folder isn't in the Xcode project. I've added them back in my fork (and updated the gitignore while i'm at it), but still haven't set a minimum-width for the popup.

Should I open a PR for this?

KevinPayravi commented 2 months ago

Installed it to my iPad and it seems like the popup doesn't have a proper minimum width

Also, none of the css for the settings or popup seem to load, since the css folder isn't in the Xcode project. I've added them back in my fork (and updated the gitignore while i'm at it), but still haven't set a minimum-width for the popup.

Should I open a PR for this?

A PR would be great, thank you! I just merged changes from main into safari last night that I believe included a CSS refactor that moved CSS into their own stylesheets (among others things), so that's likely why.