search

KevinSee / PITcleanr

Compress PIT tag capture histories for use in various analyses
https://kevinsee.github.io/PITcleanr/
Creative Commons Attribution 4.0 International
8 stars 6 forks source link

Move getNodeInfo() from DABOM to PITcleanr #35

Closed KevinSee closed 1 year ago

KevinSee commented 1 year ago

Seeing as the function uses a parent-child table and configuration file as inputs, seems to make more sense to house this within the PITcleanr package. In general, it makes sense to me to make PITcleanr as independent of other packages like STADEM or DABOM as possible, but I'm fine if DABOM or STADEM relies on PITcleanr.

KevinSee commented 1 year ago

getNodeInfo() is not really used in any other PITcleanr functions. In addition, it does contain a call to defineDabomColNms(). One suggestion might be to include a function defineCapHistCols() (using the second_node = T argument) in PITcleanr, and have getNodeInfo call that, and therefore make it easier to move getNodeInfo into PITcleanr.

Then perhaps defineDabomColNms could either be replaced by defineCapHistCols in DABOM, or modified to make use of defineCapHistCols with perhaps a few other options to help with DABOM models.

KevinSee commented 1 year ago

Everything in the previous comment has been done.