search

KevinTsui1234 / tint2

Automatically exported from code.google.com/p/tint2
GNU General Public License v2.0
1 stars 0 forks source link

Launcher using wrong icons and possibly no svg support #431

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1.specify launcher_icon_theme in rc, especially one whose icons are .svg
2.start tint2
3.see hicolor icons instead.

What is the expected output? What do you see instead?

Launcher should use GTK icon theme specified, as task bar does. Launcher will 
SOMETIMES use the correct icons depending on iconset. 

As well, I have tried with xsettingsd running, specifying the icon theme. This 
gave the same result.

The icon theme IS set everywhere else in the system, even the task bar in tint.

What version of the product are you using? On what operating system?

tint2 0.11 and built from SVN.

OS: Archlinux, Openbox standalone, themes set via lxappearance or manually via 
edit of gtkrc

Please provide any additional information below.

see screenshot for output when running tint2 and see the bar for an example of 
the problem. 3 of the programs (chromium, thunar, and geany) are running.

Thanks for looking into this.

Original issue reported on code.google.com by execute....@gmail.com on 27 May 2013 at 2:51

Attachments:

GoogleCodeExporter commented 8 years ago 
From what i can gather, the code looks for .png and .xpm icons, if it can't 
find either of these in a specified theme then it defaults to the hicolor one.

I ran into the same problem myself using 'ultra-flat-icons'.

I found this attempt at a fix using librsvg although it doesn't take into 
account the size of the SVG vs the available space: 
https://github.com/ixxra/tint2-svg/commit/aae7a0b1e147f27be182328ce2377da7d91f95
48

Original comment by r...@robbollons.com on 28 Jan 2015 at 12:52

GoogleCodeExporter commented 8 years ago

Original comment by mrovi9...@gmail.com on 28 Jan 2015 at 2:22

GoogleCodeExporter commented 8 years ago 
I'll handle this one.

Original comment by mrovi9...@gmail.com on 28 Jan 2015 at 2:23

GoogleCodeExporter commented 8 years ago 
SVG support should work in r670.

I used the rsvg library (as in the ixxra's repository, thanks for pointing that 
out). However I had trouble converting between the GdkPixbuf that rsvg returns 
and the imlib2 format used by tint2 (there were artifacts in the images); the 
only solution I found was to save the GdkPixbuf to a temporary PNG file and 
load it from disk with imlib2.

I also made improvements to the icon lookup algorithm. If it causes trouble 
please let me know.

Original comment by mrovi9...@gmail.com on 28 Jan 2015 at 2:55

GoogleCodeExporter commented 8 years ago 
Excellent, that seems to do the job for me - no ill effects as far as i can 
tell.

Cheers!

Original comment by r...@robbollons.com on 28 Jan 2015 at 8:28

GoogleCodeExporter commented 8 years ago

Original comment by mrovi9...@gmail.com on 1 Feb 2015 at 5:50

GoogleCodeExporter commented 8 years ago

Original comment by mrovi9...@gmail.com on 1 Feb 2015 at 11:49

GoogleCodeExporter commented 8 years ago 
Changed launcher_icon_theme option to work as an override. If not present, we 
use xsettings to obtain the current theme or default to hicolor if xsettings 
not present.

Thus: to use the current theme, delete/comment launcher_icon_theme in tint2rc.

Final commit in r733.

Original comment by mrovi9...@gmail.com on 20 Mar 2015 at 9:55