Open puehringer opened 1 month ago
Hi @puehringer thanks for filing this, could you advise what would your proposed solution be? Would it be adding stopPropagation()
to the event handlers as in your override? We'd need to check that it does not affect any built-in dnd functionality
If you are using any DND library that breaks native browser drag events, then don't expect the MRT dnd features to work.
Hi @puehringer thanks for filing this, could you advise what would your proposed solution be? Would it be adding
stopPropagation()
to the event handlers as in your override? We'd need to check that it does not affect any built-in dnd functionality
We have added the stopPropagation like in the override and have not encountered any issues so far. I agree that this may be a downstream react-mosaic issue, but I also don't see any issues with stopping propagation at the "source", i.e. MRT. Let me know if you need a further example, or if I should draft up a PR 👍
If you are using any DND library that breaks native browser drag events, then don't expect the MRT dnd features to work.
I agree, I haven't been able to patch it in react-mosaic though. I think it's worth a try to stop propagation at the source, or would that be breaking something? We have been using the override for quite a while now with no issues.
mantine-react-table version
v2.0.0-beta.6
react & react-dom versions
v18
Describe the bug and the steps to reproduce it
Drag and drop features are not working when used in combination with other libraries which are relying on drag/drop events.
We are currently patching the
dist/index.esm.mjs
with the overrides below to make it work. It could be that we just have to addstopPropagation()
to all drag related events to fix this.Let me know if more input is needed, and thanks for the great library and the work on v2!
Minimal, Reproducible Example - (Optional, but Recommended)
https://codesandbox.io/p/devbox/throbbing-cache-w6k7d2?file=%2Fsrc%2FTS.tsx%3A46%2C16
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
Yes, I think I know how to fix it and will discuss it in the comments of this issue
Terms