KevinVandy / mantine-react-table

A fully featured Mantine V5 implementation of TanStack React Table V8, forked from Material React Table
https://www.mantine-react-table.com/
MIT License
819 stars 136 forks source link

v2 MRT exports all `@tabler/react-icons` #418

Open sbsrnt opened 15 hours ago

sbsrnt commented 15 hours ago

mantine-react-table version

2.0.0-beta.6

react & react-dom versions

18.3.0

Describe the bug and the steps to reproduce it

When working with v2 MRT, the Network tab in devtools is having performance issues because for each tabler icons we get a chunk request thus producing over 5700 requests. image

FYI I'm not using any tabler icons in that repo.

Minimal, Reproducible Example - (Optional, but Recommended)

  1. Copy minimal example from https://github.com/sbsrnt/wire.
  2. Open network tab and pay attention to the amount of requests that are happening (5.5k+, for each icon chunk).
  3. Go to https://github.com/sbsrnt/wire/blob/master/src/layout/Content/Content.tsx and comment out <LibrariesList /> (or in LibrariesList component, comment out any code related to MRT)
  4. Notice that there are no chunk requests for tabler icons

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

No, because I do not have time to dig into it

Terms

KevinVandy commented 11 hours ago

This is just during dev mode without any tree shaking though, right?