KevinVandy / material-react-table

A fully featured Material UI V5 implementation of TanStack React Table V8, written from the ground up in TypeScript
https://material-react-table.com
MIT License
1.42k stars 401 forks source link

Cancel button in row edit #24

Closed Rizodu closed 1 year ago

Rizodu commented 2 years ago

material-react-table version

v0.26.2

Describe the bug and the steps to reproduce it

In row edit mode, when cancelling the same row a second time, the "cancel" button acts as confirm

Your Minimal, Reproducible Example (Sandbox or code snippets)

https://www.material-react-table.dev/?path=/story/features-editing-examples--editing-enabled-edit-mode-cell

Screenshots or Videos (Optional)

https://user-images.githubusercontent.com/31573205/179561322-b5d33783-b600-4727-a4e5-8ae3570b2c84.mp4

Do you intend to try to help solve this bug with your own PR?

No, because I don't know how

Terms

KevinVandy commented 2 years ago

The underlying code for the editing features may get somewhat of an overhaul soon, as a lot of TanStack Table v8 had a bunch of api changes that changed the behavior here right before it went stable.

KevinVandy commented 1 year ago

Should be fixed as of v0.35.1