KevinVandy / material-react-table

A fully featured Material UI V5 implementation of TanStack React Table V8, written from the ground up in TypeScript
https://material-react-table.com
MIT License
1.47k stars 421 forks source link

Column pinning results in empty space between a regular pinned column and a pinned mrt-row-actions column. #509

Closed nthNathan closed 1 year ago

nthNathan commented 1 year ago

material-react-table version

1.9.3

react & react-dom versions

18.2.0

Describe the bug and the steps to reproduce it

Pinning and unpinning various columns on the right side (including the "mrt-row-actions" column) results in the empty space shown in the screenshots. It may be necessary to resize the table/page width for the empty space to be visible.

Minimal, Reproducible Example - (Optional, but Recommended)

List of the relevant props I am using:

initialState={{ columnPinning: { right: ["mrt-row-actions"] }, }} enableHiding enablePinning enableRowActions

Screenshots or Videos (Optional)

Screenshot (498) Screenshot (497) Note that you can see some visual customization I've done to the row actions column, but the bug still repro'd when I removed all of the customization.

Do you intend to try to help solve this bug with your own PR?

None

Terms

KevinVandy commented 1 year ago

do you have virtualization enabled?

nthNathan commented 1 year ago

No, I don't have virtualization enabled. Should I?

KevinVandy commented 1 year ago

No, I don't have virtualization enabled. Should I?

no, virtualization can cause bugs with column pinning

ismailhelmy commented 1 year ago

I am facing the same exact issue, only in "pin to right" only. However in "pin to left" it is working fine. @nthNathan

KevinVandy commented 1 year ago

I'm aware of this issue for potential right pinning spacing problems. I might need to add a new feature to TanStack Table to fix this. Need proper end/right space tracking.

Linos2508 commented 1 year ago

Hi @KevinVandy I'm facing same issue as ismailhelmy, do you have any ETA for a potencial fix?

KevinVandy commented 1 year ago

@nthNathan @Linos2508 @ismailhelmy This should be fixed in v1.11.4