KevinVandy / material-react-table

A fully featured Material UI V5 implementation of TanStack React Table V8, written from the ground up in TypeScript
https://material-react-table.com
MIT License
1.52k stars 439 forks source link

Tab Indexes for cells #589

Open miladavarni opened 1 year ago

miladavarni commented 1 year ago

material-react-table version

1.14.0

react & react-dom versions

"react-dom": "^17.0.2", "react": "^17.0.2",

Describe the bug and the steps to reproduce it

Hi First of all, this table is absolutely amazing , thank you for your work. Is there any timeline on when the table itself becomes keyboard friendly? Currently looking at the examples, and just using my keyboard and tabbing doesn't take me into the table.

I've fixed this temporarily by adding tabIndex to my cells, I can now navigate through them. But pressing "downward" key scrolls the table down, instead of jumping to the cell ( row ) bellow it.

I'm wondering if I'm on the right track, or if you guys are working on improving accessibility ?

Thank you

Minimal, Reproducible Example - (Optional, but Recommended)

https://www.material-react-table.dev/?path=/story/styling-style-table-body-rows--disable-row-hover-effect

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

None

Terms

KevinVandy commented 1 year ago

Would you be interested in contributing this stuff?

s-light commented 10 months ago

if i understand it correctly this is not for edit mode?! but for normal navigation?

i asked for a maybe similar functionality at https://discord.com/channels/937072769831694406/1184127164845658192 (not tab index but arrow keys) my original need was the navigation in edit mode - and for this i have some basic working code.. (i will upload a example in the next days...)

and iam willing to contribute something..