KevinVillela / lovecraft

A lovecraftian nightmare!
2 stars 2 forks source link

Stores #1

Closed dotaguro closed 4 years ago

dotaguro commented 4 years ago

Syncs the game directory to my main repo @31929791.

Fixes the name of the firestore repo (had two periods) and adds an applyTo method.

Since facade returns promises and not observables, wraps the promises in an observable where necessary in game.service.ts. Honestly, I don't think observerables are buying you much for cases where you're calling the facade to do some action, having an observable in that chain just makes simple things harder because you're assuming you can get more than either "OK, done" or "OMFG things blew the hell up" (like some series of responses), and you end up having to do pipe(take(1)) just to get the result out. Seems pointless for everything except the methods where we're trying to sync player visible state.