search

KevinVillela / ynab

Tools to help me use YNAB better.
2 stars 1 forks source link

Amazon Transactions not picking up #1

Open adamgarcia4 opened 6 months ago

adamgarcia4 commented 6 months ago

Hello!

I was the one on Reddit who offered to help out. I was successfully able to clone the code, npm install, build and run the extension.

I uncategorized one of my Amazon transactions in YNAB which does match an entry from Amazon to test this out. However, I'm getting 0 amazon Transactions in the following screenshots (Being taken from the web scraping of the Amazon webpage).

It is getting quite late here, but just wanted to open this ticket to continue the conversation.

Are you getting amazon transactions being pulled through?

Btw, nice web scraping!

image image
KevinVillela commented 6 months ago

Hey, thanks for offering to help!

I do get Amazon transactions. Just to confirm, you are on the transactions page when you hit the extension? If so, then there is likely a bug in the transaction processing code. Probably the best thing to do would be to add a breakpoint in Chrome Devtools to see what's going on. Another option would be to copy your HTML and add it to one of the tests. Let me know if I can help, I'm not sure what I can do without seeing the web page itself, though.

KevinVillela commented 6 months ago

FYI I just pushed a few commits, although I don't expect them to fix this issue, just provide better error messages.

Also, it's questionable if we really want to be in the business of parsing Amazon orders pages. They look like they can get pretty hairy, and different countries have different HTML, etc. We may consider outsourcing this to another extension like https://github.com/philipmulcahy/azad, which can produce a CSV for us.

adamgarcia4 commented 6 months ago

@KevinVillela I love the idea of offloading the parsing to another extension. My question is twofold:

  1. Can we call this extension as a subroutine from within our extension?
  2. I see that they have a Paywall for accessing certain features. Do we need to copy their parsing code into our extension to get around that?
KevinVillela commented 5 months ago

Although the best user experience would be to have this extension be a subroutine of ours, I'm not sure there's an easy way of doing that. And we'd definitely want to get permission from the creator :) For now, we can probably just add some UI text saying to download the other extension and use it to create a CSV, and then we can access that file from our extension.

KevinVillela commented 5 months ago

Is this something you want to take a look at? If not, I can try to get to it this weekend.