Kevincosme / flexlib

Automatically exported from code.google.com/p/flexlib
0 stars 0 forks source link

ScrollableMenu should be more extensible #32

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In ScrollableMenu, it's unfortunate that you've got to duplicate so much of
the guts of Menu in openSubMenu().

However, you don't need to do it again in ScrollableArrowMenu.

You should create a new protected method called createSubMenu() that returns
the subclass of Menu needed, initialized in any way necessary.

Then, ScrollableArrowMenu doesn't need to override the whole openSubMenu(),
it can just override createSubMenu() part.

AND... more importantly [;)], I'd be able to just override createSubMenu()
in my custom subclass of ScrollableArrowMenu, rather than overriding
openSubMenu() yet again.

Original issue reported on code.google.com by loftl...@gmail.com on 20 Jun 2007 at 2:23

GoogleCodeExporter commented 8 years ago

Original comment by dmcc...@gmail.com on 30 Jun 2007 at 11:13

GoogleCodeExporter commented 8 years ago

Original comment by dmcc...@gmail.com on 25 Dec 2007 at 4:15

GoogleCodeExporter commented 8 years ago

Original comment by dmcc...@gmail.com on 26 Dec 2007 at 11:09

GoogleCodeExporter commented 8 years ago

Original comment by dmcc...@gmail.com on 26 Dec 2007 at 11:30

GoogleCodeExporter commented 8 years ago

Original comment by dmcc...@gmail.com on 3 Jan 2008 at 8:28