KeyPuncher / WiinUPro

Microsoft Public License
412 stars 52 forks source link

WiinUPro right stick calibration issues #116

Open trei49 opened 1 year ago

trei49 commented 1 year ago

WiinUpro 0.9.7 latest (apr 21), classic controller pro.

Bug 1: right stick calibrate does not show current calibrated settings. I just tried to recalibrate my classic controller pro's right stick for the first time since 2021 and realized it does not show my existing setting. It instead shows some absurd unplayable values I have never set before (image 1). No matter how many times I reload and accept my own saved joy.file, it displays those same values the very next time I right-click Calibrate again even though my actual settings remain as what I previously loaded.

Bug 2: deadzone values for both L+R sticks do not seem to save correctly When I set for example -X value to 4, it will always load back as 7 the next time I check. Opening the joy file shows the saved value as -1 instead (image 2). If I manually edit the joy file value to -2, the settings load back as 13. A value of 0 however saves correctly as 0. I note also that the centering values does not seem to match either, not sure if I am interpreting the joy file correctly or not.

Image 1 image 1

Image 2 image 2

KeyPuncher commented 1 year ago

I'm wondering if the parsing is messed up, do they behave as you've calibrated or as they appear?

trei49 commented 1 year ago

I believe the calibrations behave more or less as I have set, definitely not as they appear. That's why I never noticed until now.

Bug 1 isn't critical, seems largely cosmetic. But bug 2 might present an inconvenience for those who need their deadzones set precisely, especially because right stick is usually the aim stick.

Ah... not related but - if only there's a way to set up gyro for such non-gyro controllers, like how CEMU does it with a local host linking smartphone gyros via an app connected to the same network, and then just tie the phone to the controller lol.

trei49 commented 1 year ago

I just tested deleting my custom defaults and restarted wiinupro. These are the starting defaults shown before any calibration:

Left image

Right image

But the funny thing is - after I load in only my custom left one for left stick and then open the calibrate window for the right stick, the right stick now appears as if it had also have been automatically loaded with the custom left file, and thus end up showing the visuals I showed earlier (the absurd one), without actually affecting the default right stick calibrated values.