KeySplit / dapp

KeySplit helps users securely and safely recover their private keys and/or passwords
https://keysplit.io
8 stars 5 forks source link

[Feature] Responsive app design #12

Closed barrasso closed 6 years ago

barrasso commented 6 years ago

Background

The application is currently designed for mobile screen sizes only. We need some styling work done on the SCSS/CSS components so that our app looks responsive on both web and mobile. It essentially needs to work for all screen sizes.

The SCSS files can be found at: https://github.com/KeySplit/dapp/tree/beta/src/Assets/styles

User Story

I want to be able to easily navigate this application on both my mobile device and desktop computer.

Acceptance Criteria

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.1 ETH (45.83 USD @ $458.26/ETH) attached to it.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 8 months, 1 week ago. Please review their action plans below:

1) eswarasai has started work.

Will add responsive stylesheet in order handle to styles for both Desktop as well as Mobile resolutions

Learn more on the Gitcoin Issue Details page.

eswarasai commented 6 years ago

@barrasso -- Hello Mark, since there are no mockups available on how the application should look at the Desktop resolution, I'm just going to add padding around the main application and make it center aligned on the screen.

Would you mind if I update the README.md in my PR to let users know what the application is about and how to run it locally? I'd really appreciate some help here in regards with the content about the application usage. Thanks!

barrasso commented 6 years ago

@eswarasai — thanks for your help. Centering and padding the application so that it looks usable on all screen sizes would suffice.

To run the app locally:

First perform an ‘npm install’ to get the required dependencies. Then you can run the app using ‘npm start’.

In regards to the readme content, I’ve listed some resources below that describe the purpose of the application.

Background:

KeySplit helps users securely and safely recover their private keys and/or passwords. The app uses Shamir’s Secret Sharing algorithm to split and locally encrypt any string input into “shards” that can be shared with others for safe keeping.

KeySplit was conceived at the ETHDenver hackathon back in February 2018.

Some blog posts describing the use case:

eswarasai commented 6 years ago

@barrasso -- Thanks for taking time in giving me some helpful links. I'll create a PR soon which will handle the responsiveness as well as update the README.md :)

eswarasai commented 6 years ago

@barrasso -- Thanks for the quick approval around the bounty. I'll try to submit the work whenever the gas prices reduces. Right now it's way too high.

Also for creating UI/UX issues, I can create one issue with the list of all the issues that I've seen throughout the flow and fix them all for you. Maybe you can tip me later once I've fixed all of them and if it's looking good to you. Let me know if that works. Thanks!

gitcoinbot commented 6 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@eswarasai due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.1 ETH (48.73 USD @ $487.31/ETH) has been submitted by:

  1. @eswarasai
  2. @eswarasai
  3. @eswarasai
  4. @eswarasai
  5. @eswarasai
  6. @eswarasai

@barrasso please take a look at the submitted work:


gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.1 ETH (48.63 USD @ $486.33/ETH) attached to this issue has been approved & issued to @eswarasai.