search

Keyang / node-csvtojson

Blazing fast and Comprehensive CSV Parser for Node.JS / Browser / Command Line.
MIT License
2.02k stars 270 forks source link

flatKeys setting being ignored #131

Closed arrow-mjanisse closed 7 years ago

arrow-mjanisse commented 7 years ago

Upgrading my project to v1.1.1 seemed to produce a regression where headers containing periods were being processed as if they were in object notation. Reverting my project to v1.1.0 resolved the issue, so it appears to be a regression in just the last update.

Please let me know if there is any more information you'd like to know.

Keyang commented 7 years ago

Thanks for letting me know. I will fix this soon.

~Keyang

On 5 January 2017 at 22:52, arrow-mjanisse notifications@github.com wrote:

Upgrading my project to v1.1.1 seemed to produce a regression where headers containing periods were being processed as if they were in object notation. Reverting my project to v1.1.0 resolved the issue, so it appears to be a regression in just the last update.

Please let me know if there is any more information you'd like to know.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Keyang/node-csvtojson/issues/131, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCs96JRoGNuJCx78OoTEIC_1QByJWCyks5rPXRGgaJpZM4LcOED .

atufkas commented 7 years ago

Same issue here - just broke my installation after upgrading to 1.1.1. Thanks for fixing anyway. When will you probably come up with a 1.1.2?

Regards, Matthias

Keyang commented 7 years ago

I think currently latest version in npm is 1.1.2?

~Keyang

On 18 January 2017 at 14:43, Matthias Lienau notifications@github.com wrote:

Same issue here - just broke my installation after upgrading to 1.1.1. Thanks for fixing anyway. When will you probably come up with a 1.1.2?

Regards, Matthias

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Keyang/node-csvtojson/issues/131#issuecomment-273493146, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCs91xUf-rBQRfBa8oaACL4YQ-CZNwxks5rTiUagaJpZM4LcOED .

atufkas commented 7 years ago

I'm sorry, my mistake - you're right!