KeyboardKit / KeyboardKitPro

KeyboardKit Pro helps you create custom keyboards for iOS and iPadOS.
https://keyboardkit.com
Other
114 stars 8 forks source link

RTL languages long pressing "Space" moves the caret wrongly #14

Closed ez-ai21 closed 4 months ago

ez-ai21 commented 4 months ago

Current state: Gesture swipe to the right at the end of the text does nothing. Gesture swipe to the right moves the caret left. Gesture swipe to the left moves the caret right.

https://github.com/KeyboardKit/KeyboardKitPro/assets/175294009/47401758-26fd-43ea-b7ee-6fb4c484d297

Expected result: Gesture swipe to the right moves caret to the right if possible. Gesture swipe to the left moves the caret to the left if possible.

danielsaidi commented 4 months ago

Hi @ez-ai21 - does this only behave incorrectly for RTL locales?

ez-ai21 commented 4 months ago

Hi @ez-ai21 - does this only behave incorrect in RTL locales?

Correct. I believe that the caret movement should behave the same in all languages (RTL and LTR) if it is to align with Apple's approach.

danielsaidi commented 4 months ago

Ok got it, thank you! This probably broke once the SDK started applying the primary language correctly. I’ll fix it!

danielsaidi commented 4 months ago

This should work in the upcoming 8.7.2