Keycapsss / awesome-mechanical-keyboard

⌨️ A curated list of Open Source Mechanical Keyboard resources.
https://keebfolio.netlify.app/
2.93k stars 200 forks source link

Site maintenance #182

Open swift502 opened 2 days ago

swift502 commented 2 days ago

Hi. I wanted to fix the missing images, but when I saw that the site is using Astro 1 I updated everything to current versions.

This is totally unsolicited so I understand if you refuse these changes. However I'd be happy to further fix issues that might come up when building or deploying the site.

Entries cleanup

Site maintenance

Differences

Let me know what you think. πŸ‘Œ

netlify[bot] commented 2 days ago

Deploy Preview for keebfolio ready!

Name Link
Latest commit 272d64107bcf41ef0c25580810e9508ae191a60b
Latest deploy log https://app.netlify.com/sites/keebfolio/deploys/672a8b007f33360008368562
Deploy Preview https://deploy-preview-182--keebfolio.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aatmmr commented 2 days ago

Hej @swift502 - thanks a lot for you efforts πŸŽ‰ Weβ€˜ll look at it soon 😊

swift502 commented 2 days ago

After further research the search functionality could be done with Pagefind, which has good integration with astro.

swift502 commented 1 day ago

For the image optimization and loading jitter:

  1. MDX would work but then the images would not render correctly on github, when viewing the mdx files. Is that important?

  2. Another alternative would be something like yml, and generate the table html manually.

- name: Boston
  type: pcb, case
  tags: 120%, usb-c, STM32F072CBU6
  link: https://github.com/bluepylons/Boston
  image: boston.jpg # Images would be made local, so they can be optimized during build

Separate data and html that way.

Just a few proposals. But I can't find an easy way to improve the images without removing the simplicity of people being able to just add a line on Github, check the md preview to see if everything is correct and create a PR. That is a really good thing that allows people to contribute easily.