[Feature Request] Add to readme.md information about NEW_SAFE_RANGE

Keychron / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

653 stars 826 forks source link

[Feature Request] Add to readme.md information about NEW_SAFE_RANGE #240

Open paat opened 3 months ago

paat commented 3 months ago

Feature Request Type

[ ] Core functionality
[ ] Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
[X] Alteration (enhancement/optimization) of existing feature(s)
[ ] New behavior

Description

I used online tutorials to customize my Q3 Pro within keymap.c. When defining new new keycode enums I started with KC_MYKEY = SAFE_RANGE But I did not realize that Keychron added their own enums and defined NEW_SAFE_RANGE. So I spent hours debugging why bluetooth is not working with my custom build.

I would have been helpful to put information about NEW_SAFE_RANGE in readme.md.

exstntlmsnthrp commented 3 months ago

I think this may have at least some peripheral relationship to #217 in that keychron has been a little vague in sharing details regarding Bluetooth and QMK programming. Thus limiting benefits of upstream QMK and making it more difficult for users to figure out. As they seem reluctant to add other information, I'd not hold my breath waiting for this.

github-actions[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.