search

Keyfactor / ejbca-community-helm

Helm chart for deploying EJBCA in Kubernetes
GNU Lesser General Public License v2.1
14 stars 9 forks source link

Consider adding more metadata or relying on some library chart #3

Closed lazyoldbear closed 4 months ago

lazyoldbear commented 10 months ago

I am particularly missing podLabels, topologySpreadConstraints and updateStrategy.

One way of addressing that and many other things is to reuse something, like Helmet or another library chart.

svenska-primekey commented 8 months ago

That's a good idea. Do you have some examples that you could share?

lazyoldbear commented 5 months ago

Hello. I am sorry for the long delay. Here's what I mean: https://github.com/Keyfactor/ejbca-community-helm/pull/11 Please note: I did not try to deploy, only made helm template. But I hope that serves the illustration purpose.

lazyoldbear commented 5 months ago

And, obviously, the same would apply to signserver.

svenska-primekey commented 4 months ago

Your changes look awesome! could you rebase the commit. I think I understand enough to update the readme. I would really like to get your PR merged. Thank you for the contribution!

lazyoldbear commented 4 months ago

Apologies for not filling the gaps with README. We are using most of those things ourselves. Perhaps what I forgot is NetworkPolicy, but I doubt it is critical.

svenska-primekey commented 4 months ago

Closing issue now that this is merged. Thank you @lazyoldbear for the contribution!