search

Keyfactor / ejbca-vault-pki-engine

EJBCA PKI Engine and Backend for HashiCorp Vault. Used to issue, sign, and revoke certificates using the EJBCA CA.
Apache License 2.0
6 stars 2 forks source link

Avoid Fetching Ephemeral Certificate During Revoke #14

Closed carteralbrecht closed 5 months ago

carteralbrecht commented 5 months ago

You may find this helpful when working on https://github.com/Keyfactor/ejbca-vault-pki-engine/issues/13

It worked on our end when revoking ephemeral certs

The EJBCA API still threw a 409, but the cert did get revoked. That seems like a bug independent of this plugin.

This fixes the "returned certificate bytes were empty" error by simply not fetching the certificate at all.

Sorry for the random whitespace changes - don't have time to fix rn

m8rmclaren commented 5 months ago

Hey @carteralbrecht,

Thanks for this PR - I ended up making these changes in #15.