KeymashGame / game-tracker

Official Bugtracking Repository for all Keyma.sh issues
6 stars 0 forks source link

End Game button not working randomly #109

Closed aevi72 closed 3 years ago

aevi72 commented 3 years ago

Random, but very rarely the End Game button for the lobby leader breaks at the end of a match and freezes the lobby, thus forcing the lobby leader to refresh the lobby.

As of right now we have no idea how to reproduce this bug and thus don't know how to fix it. So if anyone has an idea what might be the cause of this please post it below.

Edit: It seems that the End Match (Or Abort Match) button can also be affected by that

aevi72 commented 3 years ago

Update: It seems that the button breaks when the lobby leader is reassigned and starts their first game as the leader. The button on the first game always breaks for the new lobby leader but works fine in the second game and all games following after that. (Thanks @M94SS for the help!)

It looks like the first game with a new lobby leader just outputs

42/lobby,["forceEndMatch", {}]
0: "forceEndMatch"
1: {}

and leaves out forceEndLobby, while all the other normal games output both:

42/lobby,["forceEndMatch", {}]
0: "forceEndMatch"
1: {}

42/lobby,["forceEndLobby", {}]
0: "forceEndLobby"
1: {}

The same thing applies for the "End Match" button, which a leader can press if they haven't finished the text yet.

CameronCT commented 3 years ago

Pushed update into staging - please confirm if fixed.

aevi72 commented 3 years ago

Works fine on staging.