search

KeymashGame / game-tracker

Official Bugtracking Repository for all Keyma.sh issues
6 stars 0 forks source link

Name on profile and leaderboards truncates too early #142

Closed Syndric closed 2 years ago

Syndric commented 3 years ago

Describe the bug The names on leaderboards and profiles truncate way too early. I think this is pretty unnecessary and the truncation should come a few more characters later or even be removed. There's definitely a lot more space on the leaderboard for a longer name. In addition, for the profiles I'd prefer to look at a long name causing a wonky page than to look at the name in the search bar. It's just nicer to see someone's name on a profile and not have to look at a truncated version of it.

To Reproduce Go to most wins at spot # 22 and you'll find DefinitelyNotJah's name shortened by one letter. Go to his profile and you'll see his name truncated by one letter.

Expected behavior For leaderboards, the name truncating should start around 24? characters. For profiles, names shouldn't be truncated.

CameronCT commented 3 years ago

I'll look into it, but some characters are bigger than others therefore that's why more characters are sometimes truncated compared to others.

CameronCT commented 2 years ago

Tried looking into this, but I think for now we're keeping the universal truncating. It's incredibly hard to master truncating when using different forms of letters. There's also the mobile aspect where I want to keep the text looking good on mobile and the best way to do it is to keep truncating rather than reset (even if it's for a leaderboard).