KeymashGame / game-tracker

Official Bugtracking Repository for all Keyma.sh issues
6 stars 0 forks source link

Players with long names can bug layout on ranked #87

Closed popey456963 closed 3 years ago

popey456963 commented 3 years ago

Describe the bug DefinitelyNotJah gets shortened to DefinitelyNotJa..., a name which appears to be long enough to sometimes bug the player card: image

This in turn makes the entire screen jump up and down if you're on a monitor large enough to fit in all on one screen (e.g. 1440p @ 160% zoom). This makes ranked much harder, as the text constantly jumps up and down a couple of times a second.

To Reproduce Play against someone with a long name, have them type.

Expected behavior Screen doesn't bounce around.

Screenshots image

CameronCT commented 3 years ago

Looks like we need to truncate an extra character. The issue with name truncating is that each letter can sometimes be a different width so flexbox doesn't respect that fully.

CameronCT commented 3 years ago

Fixed in v2. The playercard styling is similar between Free for All and 1v1 Duel Mode now. However it will still remain on opposite sides of each other.