Keyspace-cloud / android

Official Android client for keyspace.cloud. A beautiful and secure password manager.
https://keyspace.cloud
GNU General Public License v3.0
134 stars 9 forks source link

Authentication does not work on non-fingerprint old devices (Don't mind Spanish, I have Spanish on school :( ) #23

Open ian1ilych opened 1 year ago

ian1ilych commented 1 year ago

Description

Screenshot_20221226-122548_Settings Screenshot_20221226-122524_Keyspace

So my device is good up and running until it the app says that it took too long on authentication and so i realized this app needs a fingerprint, and my device dosen't had it.

Reproduction steps

1. Install the app on an old or older device running Android 9.0 or older
2. Sign in or Up with that device
3. Unlock the vault and Wait a few seconds or more, and done

Screenshots

No response

Device info

Galaxy J7 Star
Android 9.0
One UI 1.1
32 GB
2GB RAM
0x4f53 commented 1 year ago

Hi Ian, thanks for reporting this. We're investigating the issue and will get back to you.

0x4f53 commented 1 year ago

Hey, I tried adding a biometric hardware check. Can you test this branch and tell me if you still face this issue? https://github.com/Keyspace-cloud/android/tree/fingerprint_sensor_fix

ian1ilych commented 1 year ago

It still has it.

ian1ilych commented 1 year ago

Maybe try changing the behaviour of biometrics if it detects that it has fingerprint on your device, if it does not have it, then it will cancel and instead access normally and bypassing it.

0x4f53 commented 1 year ago

There's no way that can be done, since it goes against our security model of binding the Keyring to Keystore+BiometricPrompt (reference). I need to look into other fixes.

Interestingly enough, I tested this on a Moto G XT1033 from 2013 with an Android Pie Custom Rom and it worked just fine.

ian1ilych commented 1 year ago

So the reason why it didn't worked is because i have an official operating system called the old One UI 1.1 and you used a custom operating system with ROM.

ian1ilych commented 1 year ago

So it didn't worked, make sure it reads the model of the phone and its operating system (from most official brands), make sure it reads what brand made the model and the most important thing, what biometric supports

Macmaster14 commented 1 year ago

You're emailing the

-------- Original Message -------- On Jan 5, 2023, 10:33 AM, ian1ilych wrote:

So the reason why it didn't worked is because i have an official operating system called the old One UI 1.1 and you used a custom operating system with ROM.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Macmaster14 commented 1 year ago

You're emailing the wrong person, I have no idea who you are...

-------- Original Message -------- On Jan 5, 2023, 10:33 AM, ian1ilych wrote:

So the reason why it didn't worked is because i have an official operating system called the old One UI 1.1 and you used a custom operating system with ROM.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ian1ilych commented 1 year ago

Im ian1ilych and basically: The app had an issue where my device dosen't support fingerprints and the app needs it so im stuck with that image at the beginning.