Keyspace-cloud / android

Official Android client for keyspace.cloud. A beautiful and secure password manager.
https://keyspace.cloud
GNU General Public License v3.0
135 stars 9 forks source link

Crash logging #49

Closed 0x4f53 closed 1 year ago

0x4f53 commented 1 year ago

:recycle: Current situation

Crashes always happen ungracefully. Users often need to report them by replicating them, copying them and pasting them into ADB. This is lame.

:bulb: Proposed solution

Implement easier, dialog-based, crash log emailing. This works as such:

  1. You enjoy using Keyspace.
  2. The app crashes because developers are humans.
  3. The app gracefully exists and presents you with an alert dialog asking for your consent to email the logs to us.
  4. If you tap "Send email", your default mail client is opened (you are prompted to pick one if you don't have a default set, so make sure you have at least one mail client installed).
  5. If you tap "Cancel", nothing is sent to nobody.

📚 Release Notes

Library version bumps

📝 Testing

nimish-ks commented 1 year ago

@4f77616973 please add [Keyspace-adroid-crash report] as an email subject prefix

0x4f53 commented 1 year ago

@nimish-ks Done.

IzzySoft commented 1 year ago

Just to confirm: ACRA is just enabled for this kind of crash reporting – i.e. the user is in full control what is sent and no data leaves their system without their approval? And that's how it will stay? I just need to know as my updater just alerted me to set the Tracking flag on Keyspace as it detected the library. If you can confirm the above (and to a non-dev like me the code in this PR looks that way), I'd instead white-list ACRA for your app.

rohan-chaturvedi commented 1 year ago

Just to confirm: ACRA is just enabled for this kind of crash reporting – i.e. the user is in full control what is sent and no data leaves their system without their approval? And that's how it will stay? I just need to know as my updater just alerted me to set the Tracking flag on Keyspace as it detected the library. If you can confirm the above (and to a non-dev like me the code in this PR looks that way), I'd instead white-list ACRA for your app.

@IzzySoft Yes that is correct. We only use ACRA when the app crashes. You will be prompted with a dialog to optionally send crash logs, and if you chose to do so, your phone's default email app will be used to create an email with the logs as an attachment.

IzzySoft commented 1 year ago

Great, thanks! Then I'll now white-list ACRA for your app instead of (unnecessarily) raising the Tracking flag. Wonderful!